-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On 02/26/2013 06:56 PM, Felipe Balbi wrote: > Hi, Hi Felipe, >> e.g. f_mass_storage_usb.ko, f_ss_lb_usb.ko, f_rndis_usb.ko etc. > > IMHO each function should be a separate module, so this > f_ss_lb_usb.ko is wrong. We should have f_sourcesink.ko and > f_loopback.ko. This is true for most functions. I made serial a separate module and I believe all other functions can be done as well. I would probably strip _usb from the module name but that is another story and the function name is BOT and not mass_storage but still different story. I posted the SourceSink + LoopBack module already and assumed that it has been picked up. I merged SourceSink and LoopBack into one module because it made a lot of things easier. Both still export two function names they just happen to live in the same house to share rent. They share quite a lot code in a messy way and splitting them would require to duplicate code or creating an own module for the common code and it made things more ugly compared to the room-mate version. Since it is the same code and I would want to avoid the #include "….c" thingy so we would create a shared module which would be larger than usb-common but it doubt that it would hit 4kib in size (which means the memory to handle the module is larger than the module itself). The fact that both functions are usually used together and the very minor memory overhead we have in case we don't use the one I think it makes more sense to keep this two together than trying it to split them. Sebastian -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iQIcBAEBCAAGBQJRLP53AAoJEHuW6BYqjPXRD9sP/2mCMVnXAMrRggB07yQtZyEa xzpiSshTLgquarnVlVokKGaSXkEZa+x2m/P1K4mrAtHlm4vV8kIUnTEyZx65l/Tz fZTHwLjTpm5wSoBnxbO6TUpmPNauIHEMENbiBx2jzM3ZggqSC8LqghvWHVWHP2tz fmTGByJttIkpl9ead92n+3nWrXOJmt8L6fPulSoAPHFYsy0A7benvMKYLod/uLpl GeAYfBfxptjOr3DPc9OD837qgy4EBANiw2oZX+wt2s07CvgYFyVfcLjqWLtnjaMQ vDFDetgI9/+F7yB4CjKRGV6eMvqdPCPnvZzmb5z+FPmXMfHSwmNW+ZHlB2OaSFea zxKAxGpihsrxuDVPwuaheUgbS1ac+meKDCjrwO3bdenvXQzocfdZr+efLi2EDpHp Gza3WYJsZwxlUlHmmxBmYVgOwfIYmyg73971qPfmr0P8eC61UXnT3Udjk8j8CCNv ZB4tweLBHl9l95xQBulAUgPxHZpjpZk1fUEccMN/VZBElLWMeRLuG6uCQOI2sUi3 saRS7MzpqhetFF6QoxmwJ90OsvSLlmgDp890+HEUa409whC6X1OzPtmndWN1yWx6 alY4KvSuK4o7TZrSQXn814ACngtaiGmM+LUG0KaQypBO5PV0XxkkI0kLED97oQ2A eFeS0GQItRSoOi7Fx/en =9X6z -----END PGP SIGNATURE----- -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
