On 08/23/2012 03:07 PM, Michal Nazarewicz wrote:
Perhaps also wrap declaration of usb_gadget_get_string() with an #ifdef in include/linux/usb/gadget.h? This way, anything trying to use the function w/o USB_LIBCOMPOSITE selected will fail to compile rather than failing to load.
Good hint. The file_storage gadget which is leaving is the other user besides composite.
Also, I would personally prefer having selects in Kconfig since I don't see the need for user who compiles the kernel to know about or understand the distinction between composite and “raw” gadgets.
I tried to avoid this but can change. In the end I would like to have this "traditional" gadget and those which are created on runtime by configfs.
Other than that: Acked-by: Michal Nazarewicz<mina86@xxxxxxxxxx>
Sebastian -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
