Re: [PATCH 4/9] usb/gadget: add epautoconf.c to libcomposite

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx> writes:
> This adds epautoconf.c into libcomposite and updates all gadgets.
>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>

Acked-by: Michal Nazarewicz <mina86@xxxxxxxxxx>

> diff --git a/drivers/usb/gadget/acm_ms.c b/drivers/usb/gadget/acm_ms.c
> index 3078d79..5db661d 100644
> --- a/drivers/usb/gadget/acm_ms.c
> +++ b/drivers/usb/gadget/acm_ms.c
> @@ -42,7 +42,6 @@
>   */
>  
>  #include "composite.c"
> -#include "epautoconf.c"
>  #include "u_serial.c"
>  #include "f_acm.c"
>  #include "f_mass_storage.c"
> diff --git a/drivers/usb/gadget/audio.c b/drivers/usb/gadget/audio.c
> index 9e85df2..689d142 100644
> --- a/drivers/usb/gadget/audio.c
> +++ b/drivers/usb/gadget/audio.c
> @@ -14,6 +14,7 @@
>  #include <linux/kernel.h>
>  #include <linux/utsname.h>
>  
> +#include "gadget_chips.h"

Perhaps we should EXPORT_SYMBOL usb_gadget_controller_number() and
gadget_supports_altsettings() functions from epautoconf.c instead?  The
former does not look like it's something compiler would inline anyway.

>  #define DRIVER_DESC		"Linux USB Audio Gadget"
>  #define DRIVER_VERSION		"Feb 2, 2012"
>  
> @@ -27,7 +28,6 @@
>   * a "gcc --combine ... part1.c part2.c part3.c ... " build would.
>   */
>  #include "composite.c"
> -#include "epautoconf.c"
>  
>  /* string IDs are assigned dynamically */
>  

-- 
Best regards,                                         _     _
.o. | Liege of Serenely Enlightened Majesty of      o' \,=./ `o
..o | Computer Science,  Michał “mina86” Nazarewicz    (o o)
ooo +----<email/xmpp: mpn@xxxxxxxxxx>--------------ooO--(_)--Ooo--

Attachment: pgpfQK5D0WIST.pgp
Description: PGP signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux