Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx> writes: > This patch aims to be simple. It removes #include usbstribgs.c line from each > gadget and creats libcomposite.ko which has only one member, that is > usbstribgs.c. > To avoid mass select statements in Kconfig I simply group the composite > based gadgets together. The three gadgets which are not part of the group > are: > - EHCI Debug Device Gadget. Could be converted to composite if anyone > cares > - File-backed Storage Gadget. Replaced by "mass storage", will be > removed soon. > - Gadget Filesystem. Functionality is provided by "Function Filesystem". > Unfortunatelly can't be replaced because the user space visible API is > different. > > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx> Perhaps also wrap declaration of usb_gadget_get_string() with an #ifdef in include/linux/usb/gadget.h? This way, anything trying to use the function w/o USB_LIBCOMPOSITE selected will fail to compile rather than failing to load. Also, I would personally prefer having selects in Kconfig since I don't see the need for user who compiles the kernel to know about or understand the distinction between composite and “raw” gadgets. Other than that: Acked-by: Michal Nazarewicz <mina86@xxxxxxxxxx> -- Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o ..o | Computer Science, Michał “mina86” Nazarewicz (o o) ooo +----<email/xmpp: mpn@xxxxxxxxxx>--------------ooO--(_)--Ooo--
Attachment:
pgpwqA91gAxlb.pgp
Description: PGP signature
