Re: [PATCH 2/9] usb/libcomposite: move config.c into libcomposite

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx> writes:
> This moves config.c into libcomposite and updates all gadgets.
>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>

Acked-by: Michal Nazarewicz <mina86@xxxxxxxxxx>

> diff --git a/drivers/usb/gadget/config.c b/drivers/usb/gadget/config.c
> index 7542a72..e3a9892 100644
> --- a/drivers/usb/gadget/config.c
> +++ b/drivers/usb/gadget/config.c
> @@ -12,6 +12,7 @@
>  #include <linux/errno.h>
>  #include <linux/slab.h>
>  #include <linux/kernel.h>
> +#include <linux/module.h>
>  #include <linux/list.h>
>  #include <linux/string.h>
>  #include <linux/device.h>
> @@ -53,7 +54,7 @@ usb_descriptor_fillbuf(void *buf, unsigned buflen,
>  	}
>  	return dest - (u8 *)buf;
>  }
> -
> +EXPORT_SYMBOL_GPL(usb_descriptor_fillbuf);

Interestingly, this is only used in composite.c and config.c, so maybe
in the end we would be able to drop this EXPORT_SYMBOL?

>  /**
>   * usb_gadget_config_buf - builts a complete configuration descriptor
> @@ -106,6 +107,7 @@ int usb_gadget_config_buf(
>  	cp->bmAttributes |= USB_CONFIG_ATT_ONE;
>  	return len;
>  }
> +EXPORT_SYMBOL_GPL(usb_gadget_config_buf);
>  
>  /**
>   * usb_copy_descriptors - copy a vector of USB descriptors
> @@ -155,4 +157,4 @@ usb_copy_descriptors(struct usb_descriptor_header **src)
>  
>  	return ret;
>  }
> -
> +EXPORT_SYMBOL_GPL(usb_copy_descriptors);

-- 
Best regards,                                         _     _
.o. | Liege of Serenely Enlightened Majesty of      o' \,=./ `o
..o | Computer Science,  Michał “mina86” Nazarewicz    (o o)
ooo +----<email/xmpp: mpn@xxxxxxxxxx>--------------ooO--(_)--Ooo--

Attachment: pgpvIcMiQ1v5o.pgp
Description: PGP signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux