Re: [PATCH 1/9] usb/gadget: start with libcomposite

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 23 Aug 2012, Sebastian Andrzej Siewior wrote:

> This patch aims to be simple. It removes #include usbstribgs.c line from each
> gadget and creats libcomposite.ko which has only one member, that is
> usbstribgs.c.
> To avoid mass select statements in Kconfig I simply group the composite
> based gadgets together. The three gadgets which are not part of the group
> are:
> - EHCI Debug Device Gadget. Could be converted to composite if anyone
>   cares
> - File-backed Storage Gadget. Replaced by "mass storage", will be
>   removed soon.
> - Gadget Filesystem. Functionality is provided by "Function Filesystem".
>   Unfortunatelly can't be replaced because the user space visible API is
>   different.

> --- a/drivers/usb/gadget/Kconfig
> +++ b/drivers/usb/gadget/Kconfig
> @@ -507,6 +507,16 @@ config USB_GADGET_SUPERSPEED
>  #
>  # USB Gadget Drivers
>  #
> +
> +# composite based drivers
> +config USB_LIBCOMPOSITE
> +	tristate "Lib composite based gadgets"
> +	depends on USB_GADGET

Shouldn't this have "default USB_GADGET"?  There will be very few cases
where anyone wants to configure a system with gadget support but
without libcomposite.

> +	help
> +	  Most gadgets are using the composite framework. There are only three

s/framework/library/

> +	  gadgets left which do not use the composite framework and two of them

Ditto.

> +	  have been replaced by alternatives.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux