Hi, On Mon, Aug 20, 2012 at 09:35:22AM +0200, Sebastian Andrzej Siewior wrote: > I'm not going to swear here. The Android gadget includes composite.c > from the main tree and overwrites functions. This would still work if I > rename it and remove the const attribute but the problem rises again > once we stop including composite.c and use it as a library function. > > Cc: devel@xxxxxxxxxxxxxxxxxxxx > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx> If ccg needs a different setup method, it's completely non-standard. I don't think it should be using composite.c at all. Just make ccg a standalone gadget non-dependent on this composite.c and let's move on. If later ccg wants to continue to exist in the kernel, they need to adapt to composite.c properly, instead of hacking its own stuff on composite.c's setup method. -- balbi
Attachment:
signature.asc
Description: Digital signature
