Re: [PATCH 3/9] usb/gadgets: move bind() callback back to struct usb_composite_driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 08/22/2012 01:33 PM, Felipe Balbi wrote:
I don't think you should split this from patch 1, otherwise before this
patch no gadget driver will work, right ?

In #1 I have

@@ -1639,7 +1640,8 @@ int usb_composite_probe(struct usb_composite_driver *driver,
        composite_driver.max_speed =
                min_t(u8, composite_driver.max_speed, driver->max_speed);
        composite = driver;
-       composite_gadget_bind = bind;
+       if (!driver->bind)
+               driver->bind = bind;

        return usb_gadget_probe_driver(&composite_driver, composite_bind);
 }

which sets the callback for all users which do not set it. So no,
nothing should break.

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux