Re: [PATCH 6/9] usb/gadget: remove global struct usb_composite_driver in composite

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Aug 15, 2012 at 09:59:16PM +0200, Sebastian Andrzej Siewior wrote:
> The direct user of the gadget driver (composite, dbgp, inode,
> file_storage) keeps a global variable where it stores a pointer to
> something which identifies the "current" instance from the time calling
> usb_gadget_probe_driver() and later in its ->bind() callback.
> This patch passes the struct usb_gadget_driver as an argument. Since it
> is embedded in the private struct of its user (composite, …), the user
> can restore its original data structure and avoid having a global
> pointer.
> Composite is embedding struct usb_gadget_driver. Others are unchanged.
> Only the "old-style" UDC drivers have to be touched here, new style are
> doing it right because this change is made in udc-core.
> 
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>

looks good.

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux