On 06/26/2012 08:10 PM, ABRAHAM, KISHON VIJAY wrote: >> In debug level I'm getting this warning, when I add two USB2 PHYs: > > yeah. I've kept that as a debug print for users who try to usb_add_phy > without being able to usb_get_phy_by_phandle. In that case there is no > way to get the phy which is added second. Yes. >> mxs_phy 8007e000.usbphy: transceiver type USB2 PHY already exists >> >>>> Without this patch the phy types has to be different. If this patch >>>> gets merged that restriction is removed. (You can add 2 phys without >>>> any constraints). >> >> The lengthy code snipped folds now to this: >> >> data->phy = devm_usb_get_phy_by_phandle(&pdev->dev, "fsl,usbphy"); >> if (data->phy) > When you send the final patch, make sure to use > IS_ERR_OR_NULL(data->phy) for the above check. Thanks, will do. > >> usb_phy_init(data->phy); >> ci13xxx_imx_platdata.phy = data->phy; >> >> and it work! > Thanks :-) > >> >> Next question, who is going to pick up Felipe's tree, your patch and >> finally Richard's patches? There are some trivial merge conflicts and my >> adoption of the ci13xxx_imx.c glue code. > Felipe will send pull request to greg. We have to wait for Felipe to > review this patch before it can end up in his tree. Richard patches will go to Greg, too. Let's see who will get merged, first. Maybe you both coordinate, as the tree have some conflicts and it would be fine if the ci13xxx_imx driver will use your devm_usb_get_phy_by_phandle from the very beginning. Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
Attachment:
signature.asc
Description: OpenPGP digital signature
