Hi, On Tue, Jun 26, 2012 at 9:41 PM, Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx> wrote: > On 06/26/2012 05:27 PM, ABRAHAM, KISHON VIJAY wrote: >>>> But we have two USB2 phys in the system, will 2 usb_add_phy() work? >> >> Ofcourse you'll need multi-phy support patches for it. Felipe has >> already queued it in his tree. >> git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git xceiv. > > nice :) > > In debug level I'm getting this warning, when I add two USB2 PHYs: yeah. I've kept that as a debug print for users who try to usb_add_phy without being able to usb_get_phy_by_phandle. In that case there is no way to get the phy which is added second. > > mxs_phy 8007e000.usbphy: transceiver type USB2 PHY already exists > >>> Without this patch the phy types has to be different. If this patch >>> gets merged that restriction is removed. (You can add 2 phys without >>> any constraints). > > The lengthy code snipped folds now to this: > > data->phy = devm_usb_get_phy_by_phandle(&pdev->dev, "fsl,usbphy"); > if (data->phy) When you send the final patch, make sure to use IS_ERR_OR_NULL(data->phy) for the above check. > usb_phy_init(data->phy); > ci13xxx_imx_platdata.phy = data->phy; > > and it work! Thanks :-) > > Next question, who is going to pick up Felipe's tree, your patch and > finally Richard's patches? There are some trivial merge conflicts and my > adoption of the ci13xxx_imx.c glue code. Felipe will send pull request to greg. We have to wait for Felipe to review this patch before it can end up in his tree. Thanks Kishon -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
