On 06/26/2012 01:23 PM, ABRAHAM, KISHON VIJAY wrote: [...] >>> This is like bypassing the otg_library to add or get the phy :-( >> >> The problem is, we don't have _the_ phy, we have one phy per usb port >> and we have two USB ports. > > I think then this patch would solve your problem as it allows to add > multiple-phys of the same type? We have two USB ports, a OTG capable and a host-only one. Each one has a phy, which is used in the host mode and (if the USB port supports) in the peripheral mode. I didn't follow you multi phy patches closely, what's the exact meaning of type here. If this has already been discussed you can point me to the appropriate thread. >>> Ideally you should make use of the otg library function for it. Having >>> a generic function in the otg library to get phy by phandle will help >>> other phy users to use it instead of implementing their own version of >>> get_phy from phandle. >> >> +1 >> >> The code I pointed you at is the topmost patch in: >> https://github.com/riczhao/kernel-imx/commits/topics/usb-driver >> As soon as your code is available, let's convert it to use your generic >> function. > > Cool. Thanks :-) I pointed you to the code to make sure it fits our use case. To be precise, we have two of these usb to usbphy links in the dev-tree: usb0: usb@80080000 { compatible = "fsl,imx28-usb", "fsl,imx27-usb"; reg = <0x80080000 0x10000>; interrupts = <93>; fsl,usbphy = <&usbphy0>; status = "disabled"; }; usb1: usb@80090000 { compatible = "fsl,imx28-usb", "fsl,imx27-usb"; reg = <0x80090000 0x10000>; interrupts = <92>; fsl,usbphy = <&usbphy1>; status = "disabled"; }; usbphy0: usbphy@8007c000 { compatible = "fsl,imx28-usbphy", "fsl,imx23-usbphy"; reg = <0x8007c000 0x2000>; status = "disabled"; }; usbphy1: usbphy@8007e000 { compatible = "fsl,imx28-usbphy", "fsl,imx23-usbphy"; reg = <0x8007e000 0x2000>; status = "disabled"; }; Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
Attachment:
signature.asc
Description: OpenPGP digital signature
