On 06/26/2012 05:27 PM, ABRAHAM, KISHON VIJAY wrote: >>> But we have two USB2 phys in the system, will 2 usb_add_phy() work? > > Ofcourse you'll need multi-phy support patches for it. Felipe has > already queued it in his tree. > git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git xceiv. nice :) In debug level I'm getting this warning, when I add two USB2 PHYs: mxs_phy 8007e000.usbphy: transceiver type USB2 PHY already exists >> Without this patch the phy types has to be different. If this patch >> gets merged that restriction is removed. (You can add 2 phys without >> any constraints). The lengthy code snipped folds now to this: data->phy = devm_usb_get_phy_by_phandle(&pdev->dev, "fsl,usbphy"); if (data->phy) usb_phy_init(data->phy); ci13xxx_imx_platdata.phy = data->phy; and it work! Next question, who is going to pick up Felipe's tree, your patch and finally Richard's patches? There are some trivial merge conflicts and my adoption of the ci13xxx_imx.c glue code. Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
Attachment:
signature.asc
Description: OpenPGP digital signature
