Hi, On Sun, Apr 22, 2012 at 01:36:42AM -0700, Ido Shayevitz wrote: > >> >> So, instead, maybe create a local array used for non xhci resource: > >> >> struct resource mem_res_exclude_xhci[1]; > >> >> ... > >> >> res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > >> >> ... > >> >> mem_res_exclude_xhci[0].start = res->start + 0xc100; > >> >> mem_res_exclude_xhci[0].end = res->end; > >> >> mem_res_exclude_xhci[0].flags = res.flags; > >> > > >> > and at which point do we let xHCI know what address it should request > >> > and ioremap ? > >> > >> It is already known to the XHCI, isn't it ? > >> > >> From host.c : > >> > >> /* setup resources */ > >> generic_resources[0].start = dwc->irq; > >> > >> generic_resources[1].start = dwc->res->start; > >> generic_resources[1].end = dwc->res->start + 0x7fff; > > > > that needs to change, I will drop generic_resources array and just pass > > dwc->res. > > I am at exactly the same stage, testing xCHI on dwc3, so I need this fix > too. Do you want me to help in this and patch the fix ? Sure, please go ahead. > Also what do you think of what I suggested about not changing the > addresses in core.h, but instead changing dwc3_readl and dwc3_writel ? That's doable, provided compiler doesn't generate s**t code, but then again, you would be subtracting a constant out of the addresses, so it should be fine. Can you patch that out too and make sure compiler isn't generating c**p ? -- balbi
Attachment:
signature.asc
Description: Digital signature
