Am Sonntag, 22. April 2012, 13:53:32 schrieb Ming Lei: > >> Then we can have a uniform lock requirement and no changes are involved > >> on host controller drivers. > > > > The return values would not be correct. > > If you run 'git grep -n usb_unlink_urb drivers/usb/', it may show that > most of callers do not check its return value, and the others only check > for dumping warnings. If usb_unlink_urb is converted into tasklet > implementation, we still can dump these warnings inside its tasklet function. That is a very bad idea. You make implementing a proper reference count next to impossible this way. And it makes no sense. If you use a work queue you can use usb_kill_urb() anyway. Regards Oliver -- - - - SUSE LINUX Products GmbH, GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 16746 (AG Nürnberg) Maxfeldstraße 5 90409 Nürnberg Germany - - - -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
