Re: [RFC/PATCH 2/2] usb: dwc3: core: split host address space

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Felipe,

>>
>> I am at exactly the same stage, testing xCHI on dwc3, so I need this fix
>> too. Do you want me to help in this and patch the fix ?
>
> Sure, please go ahead.
>
>> Also what do you think of what I suggested about not changing the
>> addresses in core.h, but instead changing dwc3_readl and dwc3_writel ?
>
> That's doable, provided compiler doesn't generate s**t code, but then
> again, you would be subtracting a constant out of the addresses, so it
> should be fine. Can you patch that out too and make sure compiler isn't
> generating c**p ?

dwc3_readl and dwc3_writel are also in use by dwc3_omap.c with diffrent
base address..., so there are 2 options :
1. Make diffrent version for dwc3_omap (dwc3_omap_readl/writel) and change
dwc3_readl/writel.
2. Leave dwc3_readl/writel as it is, but instead add the following line in
dwc3_probe after the ioremap:

regs = devm_ioremap(dev, res->start, resource_size(res));
if (!regs) {
	dev_err(dev, "ioremap failed\n");
	return -ENOMEM;
}
+ regs -= 0xc100;

Let me know what you prefer, I don't mind.

> --
> balbi
>

Thanks,
Ido
-- 
Consultant for Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux