On Mon, Apr 23, 2012 at 03:08:30AM -0700, Ido Shayevitz wrote: > > Hi Felipe, > > >> > >> I am at exactly the same stage, testing xCHI on dwc3, so I need this fix > >> too. Do you want me to help in this and patch the fix ? > > > > Sure, please go ahead. > > > >> Also what do you think of what I suggested about not changing the > >> addresses in core.h, but instead changing dwc3_readl and dwc3_writel ? > > > > That's doable, provided compiler doesn't generate s**t code, but then > > again, you would be subtracting a constant out of the addresses, so it > > should be fine. Can you patch that out too and make sure compiler isn't > > generating c**p ? > > dwc3_readl and dwc3_writel are also in use by dwc3_omap.c with diffrent > base address..., so there are 2 options : > 1. Make diffrent version for dwc3_omap (dwc3_omap_readl/writel) and change > dwc3_readl/writel. add dwc3_omap_read/write helpers. I guess it's better ;-) -- balbi
Attachment:
signature.asc
Description: Digital signature
