> -----Original Message----- > From: Mehresh Ramneek-B31383 > Sent: Friday, February 17, 2012 7:24 PM > To: Liu Shengzhou-B36685; linux-usb@xxxxxxxxxxxxxxx > Subject: RE: [PATCH][v4]fsl/usb:Add controller version based ULPI and > UTMI phy support > > Your observation is right, the phy initialization has already been done > inside ehci_fsl_usb_setup(). > > But, all phy initialization should be done inside ehci_fsl_setup_phy(), > as suggested by the name of the function. > > I'll float a patch to remove phy initialization from inside > ehci_fsl_usb_setup(). > > Phy initialization inside this patch should retain...as it is inside > ehci_fsl_setup_phy(). > > Thanks for your input. > > Regards, > Ramneek [Shengzhou] USB_CTRL_USB_EN should be inside ehci_fsl_usb_setup() as it's already, It shouldn't be inside ehci_fsl_setup_phy(), because it's to enable USB interface, not just for USB PHY interface. It'll cause other trouble if you remove USB_CTRL_USB_EN from ehci_fsl_usb_setup(), It's better to remove USB_CTRL_USB_EN from ehci_fsl_setup_phy(). -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
