> -----Original Message----- > From: linux-usb-owner@xxxxxxxxxxxxxxx [mailto:linux-usb- > owner@xxxxxxxxxxxxxxx] On Behalf Of Shengzhou Liu > Sent: Friday, February 17, 2012 11:49 AM > To: linux-usb@xxxxxxxxxxxxxxx > Subject: Re: [PATCH][v4]fsl/usb:Add controller version based ULPI and > UTMI phy support > > [....] > > case FSL_USB2_PHY_ULPI: > > + if (contr_ver) { > > + /* controller version 1.6 or above */ > > + ctrl = __raw_readl(&usb_sys_regs->control); > > + ctrl &= ~USB_CTRL_UTMI_PHY_EN; > > + ctrl |= USB_CTRL_USB_EN; > > [Shengzhou] here "ctrl |= USB_CTRL_USB_EN" looks a duplication to enable > PHY interface, it already had been enable in ehci_fsl_usb_setup(), is > there any reason to do it again? > The code you are referring to is gadget driver code, however, ehci_fsl_usb_setup() is part of host driver!! How can enablement of something inside host driver work for gadget driver ? - Ramneek > [....] > > case FSL_USB2_PHY_UTMI: > > + if (contr_ver) { > > + /* controller version 1.6 or above */ > > + ctrl = __raw_readl(&usb_sys_regs->control); > > + ctrl |= (USB_CTRL_UTMI_PHY_EN | USB_CTRL_USB_EN); > ditto > Same as above - Ramneek > > -- > To unsubscribe from this list: send the line "unsubscribe linux-usb" in > the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at > http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
