[....]
> case FSL_USB2_PHY_ULPI:
> + if (contr_ver) {
> + /* controller version 1.6 or above */
> + ctrl = __raw_readl(&usb_sys_regs->control);
> + ctrl &= ~USB_CTRL_UTMI_PHY_EN;
> + ctrl |= USB_CTRL_USB_EN;
[Shengzhou] here "ctrl |= USB_CTRL_USB_EN" looks a duplication to enable PHY
interface, it already had been enable in ehci_fsl_usb_setup(), is there any
reason to do it again?
[....]
> case FSL_USB2_PHY_UTMI:
> + if (contr_ver) {
> + /* controller version 1.6 or above */
> + ctrl = __raw_readl(&usb_sys_regs->control);
> + ctrl |= (USB_CTRL_UTMI_PHY_EN | USB_CTRL_USB_EN);
ditto
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
