> -----Original Message----- > From: Liu Shengzhou-B36685 > Sent: Friday, February 17, 2012 2:14 PM > To: Mehresh Ramneek-B31383; linux-usb@xxxxxxxxxxxxxxx > Subject: RE: [PATCH][v4]fsl/usb:Add controller version based ULPI and > UTMI phy support > > > > -----Original Message----- > > From: Mehresh Ramneek-B31383 > > Sent: Friday, February 17, 2012 4:26 PM > > To: Liu Shengzhou-B36685; linux-usb@xxxxxxxxxxxxxxx > > Subject: RE: [PATCH][v4]fsl/usb:Add controller version based ULPI and > > UTMI phy support > > > > > -----Original Message----- > > > From: linux-usb-owner@xxxxxxxxxxxxxxx [mailto:linux-usb- > > > owner@xxxxxxxxxxxxxxx] On Behalf Of Shengzhou Liu > > > Sent: Friday, February 17, 2012 11:49 AM > > > To: linux-usb@xxxxxxxxxxxxxxx > > > Subject: Re: [PATCH][v4]fsl/usb:Add controller version based ULPI > > > and UTMI phy support > > > > > > [....] > > > > case FSL_USB2_PHY_ULPI: > > > > + if (contr_ver) { > > > > + /* controller version 1.6 or above */ > > > > + ctrl = __raw_readl(&usb_sys_regs->control); > > > > + ctrl &= ~USB_CTRL_UTMI_PHY_EN; > > > > + ctrl |= USB_CTRL_USB_EN; > > > > > > [Shengzhou] here "ctrl |= USB_CTRL_USB_EN" looks a duplication to > > > enable PHY interface, it already had been enable in > > > ehci_fsl_usb_setup(), is there any reason to do it again? > > > > > The code you are referring to is gadget driver code, however, > > ehci_fsl_usb_setup() is part of host driver!! > > How can enablement of something inside host driver work for gadget > > driver ? > > - Ramneek > > [Shengzhou] sorry, I thought to refer to the code in ehci-fsl.c, I placed > my previous comments in wrong place. > I mean you still make a duplication of enablement with USB_CTRL_USB_EN in > host driver code, it's unnecessary. Your observation is right, the phy initialization has already been done inside ehci_fsl_usb_setup(). But, all phy initialization should be done inside ehci_fsl_setup_phy(), as suggested by the name of the function. I'll float a patch to remove phy initialization from inside ehci_fsl_usb_setup(). Phy initialization inside this patch should retain...as it is inside ehci_fsl_setup_phy(). Thanks for your input. Regards, Ramneek -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
