-----Original Message----- From: linux-usb-owner@xxxxxxxxxxxxxxx [mailto:linux-usb-owner@xxxxxxxxxxxxxxx] On Behalf Of Mehresh Ramneek-B31383 Sent: Saturday, February 04, 2012 10:25 AM To: Chen Peter-B29397; Shawn Guo Cc: linux-usb@xxxxxxxxxxxxxxx; Guo Shawn-R65073; Zhao Richard-B20223 Subject: RE: [PATCH][v2]fsl/usb:Add controller version based ULPI and UTMI phy support -----Original Message----- From: Chen Peter-B29397 Sent: Saturday, February 04, 2012 7:14 AM To: Mehresh Ramneek-B31383; Shawn Guo Cc: linux-usb@xxxxxxxxxxxxxxx; Guo Shawn-R65073; Zhao Richard-B20223 Subject: RE: [PATCH][v2]fsl/usb:Add controller version based ULPI and UTMI phy support > > [Ramneek]: This is not about breaking existing users. The whole intent > of this patch is to discourage people from contaminating IP (USB) code > with SOC based code...it a step in forward direction. > > I'm sure that there should be a way in which this code can also be > used for non-dt users. Can you point me to which socs you are facing issues ? > Hi Ramneek, In fact, there is no device tree support for i.mx usb driver. We plan to move all PHY's operation to PHY driver once the generic PHY driver has mainlined. It is better only do controller(chipidea IP) related operation at fsl_udc_core.c as every SoC may has different PHY. I just don't want your patch to break current user, you will find there is #ifndef CONFIG_ARCH_MXC condition to usb_sys_regs at current code. [Ramneek]: Hi Shawn, I just checked that the code will not break USB on IMX platforms. For non-DT users, the function usb_get_ver_info() will simply return 0, and the same code will run for these platforms. Please check the definition of usb_get_ver_info(). It returns 0 for all previous controllers, and this lets the phy initialization code inside dr_controller_setup() to be the same. I have come to know that the USB controller version inside mode IMX socs is 2.0. this means that the code will remain the same for them. I'll send another version of this patch with comments added for non-DT users. Regards, Rameek > Regards, > Ramneek > -- > Regards, > Shawn > -- > To unsubscribe from this list: send the line "unsubscribe linux-usb" > in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo > info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
