Re: [PATCH][v2]fsl/usb:Add controller version based ULPI and UTMI phy support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Ramneek,

Can you fix your email client to have the message wrapped around
column 70?

On Fri, Feb 03, 2012 at 02:59:58PM +0000, Mehresh Ramneek-B31383 wrote:
...
> The USB is still one missing piece from imx device tree migration.  That said if this patch introduce any change that breaks existing users (e.g.
> imx here), it should not be accepted.
> 
> [Ramneek]: Hi Shawn, rather than asking people to not to accept patches that will ease code maintainability for longer term, we should think about getting things right in imx tree. Getting on version number in a devive-tree is a very simple thing which can be done very fast. Just because people have no time to get this done for imx socs, why should whole range of fsl qoriq and other families suffer!!
> 
I re-iterate that any code change should never break any existing users.

Instead of simply breaking all those non-dt users, your patch should
provide a solution for them to migrate to.  I'm saying the driver
should accept the data it needs from either device tree (for dt users)
or platform data (for non-dt users).

-- 
Regards,
Shawn
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux