-----Original Message----- From: Shawn Guo [mailto:shawn.guo@xxxxxxxxxx] Sent: Friday, February 03, 2012 8:38 PM To: Chen Peter-B29397 Cc: Mehresh Ramneek-B31383; linux-usb@xxxxxxxxxxxxxxx; Guo Shawn-R65073; Zhao Richard-B20223 Subject: Re: [PATCH][v2]fsl/usb:Add controller version based ULPI and UTMI phy support On Fri, Feb 03, 2012 at 08:16:51AM +0000, Chen Peter-B29397 wrote: > > On Mon, Jan 30, 2012 at 12:36:12PM +0530, Ramneek Mehresh wrote: ... > > Hi ramneek, Freescale i.MX SoCs also use fsl_udc_core.c for device > > function. > > Can you change the patch and let your added code can be not called > > by i.mx SoC? > > Host is ok, as it uses ehci-mxc.c. > > > > [Ramneek]: Hi Peter, the basic thinking behind this patch is that > > fsl usb driver should not be concerned with the SOC. It should only > > be concerned with controller/IP version. This is done to prevent > > driver code contamination with SOC based code/macros. Moving > > forward, this code change will ensure easy code maintainability for fsl usb driver ... > > > > To make this code work for all fsl qoriq and older plarforms, I sent > > a patch for "controller version" information inside all platform > > device- trees. I would recommend the same for i.mx. please let me > > know if you need help for including controller version info for i.mx > > platforms > > > You mean for all controllers information for i.mx at device-tree file? > I have cc-ed i.mx device-tree guys, I don't know the progress for i.mx > device tree. The USB is still one missing piece from imx device tree migration. That said if this patch introduce any change that breaks existing users (e.g. imx here), it should not be accepted. [Ramneek]: Hi Shawn, rather than asking people to not to accept patches that will ease code maintainability for longer term, we should think about getting things right in imx tree. Getting on version number in a devive-tree is a very simple thing which can be done very fast. Just because people have no time to get this done for imx socs, why should whole range of fsl qoriq and other families suffer!! -- Regards, Shawn -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
