Oliver Neukum <oliver@xxxxxxxxxx> writes:
> Am Dienstag, 24. Januar 2012, 00:52:03 schrieb Bjørn Mork:
>> +void wdm_deregister(struct usb_interface *intf)
>> +{
>> + wdm_disconnect(intf);
>> +}
>> +EXPORT_SYMBOL(wdm_deregister);
>
> Again, the names are too indistinct.
OK.
>> +
>> #ifdef CONFIG_PM
>> static int wdm_suspend(struct usb_interface *intf, pm_message_t message)
>> {
>> diff --git a/drivers/usb/class/cdc-wdm.h b/drivers/usb/class/cdc-wdm.h
>> new file mode 100644
>> index 0000000..ff6a47c
>> --- /dev/null
>> +++ b/drivers/usb/class/cdc-wdm.h
>
> If we do this at all, we do it right and public. This belongs into include/linux/usb
Absolutely. A consequece of me doing my own testing on a stock Debian
kernel, using the Debian headers, and not something for the world to
see. One of the many things I didn't take my time to clean up until I
knew that there was a point.
This was never meant to be submitted like this, just as a request for
comments on the basic concepts. And given your extensive review I take
it that it's not out of the question doing things like this? After
fixing up the issues you've already commented and probably some more, of
course.
Bjørn
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
