Re: [PATCH experimental 3/6] usb: cdc-wdm: create an extra indirection when looking up device data

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Oliver Neukum <oliver@xxxxxxxxxx> writes:

> Am Dienstag, 24. Januar 2012, 00:52:01 schrieb Bjørn Mork:
>> Preparing for having another driver owning the interface.
>> 
>> Signed-off-by: Bjørn Mork <bjorn@xxxxxxx>
>> ---
>>  drivers/usb/class/cdc-wdm.c |   18 ++++++++++++------
>>  1 files changed, 12 insertions(+), 6 deletions(-)
>> 
>> diff --git a/drivers/usb/class/cdc-wdm.c b/drivers/usb/class/cdc-wdm.c
>> index 1e28100..684e89b 100644
>> --- a/drivers/usb/class/cdc-wdm.c
>> +++ b/drivers/usb/class/cdc-wdm.c
>> @@ -115,6 +115,12 @@ struct wdm_device {
>>  
>>  static struct usb_driver wdm_driver;
>>  
>> +static struct wdm_device *wdm_get_device(struct usb_interface *intf)
>
> The name has to be changed get/put usually implies a reference count.
> Please call it something like wdm_find_device()

Will do.  Should have done so in the first place.


Bjørn
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux