On 08/31/2011 05:16 PM, ABRAHAM, KISHON VIJAY wrote: > On Mon, Aug 29, 2011 at 3:36 PM, Sergei Shtylyov <sshtylyov@xxxxxxxxxx> wrote: >> Hello. >> >> On 29-08-2011 1:21, Sebastian Andrzej Siewior wrote: >> >>> Use platform helper to obtain irq& mem region instead OF helper. We get a >>> complete platform device out of every OF node so there is no need to use >>> OF helper for the standarf stuff. >> >>> Signed-off-by: Sebastian Andrzej Siewior<sebastian@xxxxxxxxxxxxx> >>> --- >>> drivers/usb/host/ehci-xilinx-of.c | 16 ++++++++-------- > there are some OF functions used in file drivers/usb/host/ehci-grlib.c > as well. Is there any reason why you dint modify ehci-grlib.c? > platform_get_irq() / platform_get_resource(.., IORESOURCE_IRQ, ..) is broken on SPARC32 (at least for LEON) so a change like: >>> - irq = irq_of_parse_and_map(dn, 0); >>> + irq = platform_get_irq(op, 0); will break ehci-grlib.c. A colleague of mine has adding support for platform_get_irq() on his todo list, but it will probably be a while before it gets sorted out. My guess is that most people that use ehci-grlib use a kernel distributed by my employer. If the use of irq_of_parse_and_map() stands in the way of the ehci registration rework then please go ahead and remove it - we can temporarily carry a workaround in our linux dist. Best regards, Jan -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
