Re: [PATCH 1/1] drivers/usb/host/xhci.c: Redundant check in xhci_check_args for xhci->devs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Wed, Aug 31, 2011 at 9:51 PM, Sarah Sharp
<sarah.a.sharp@xxxxxxxxxxxxxxx> wrote:
> Hi Sifram,
>
> This version applies fine to my for-usb-next branch, so I'll send it off
> to Greg today.  Thanks for taking the time to work through our hairy
> patch submission process. :)  I hope it will be easier for you to send
> your next patch!
>

No problem at all. I an thoroughly enjoying the learning process of it all. :)
I am now using git for everything so I don't think anything will go wrong.

I would like to take this opportunity to ask you one more question:

How can I start submitting patches for all other drivers and kernel code ?
Could you give me a few pointers to how I can randomly pick up a
driver and start
contributing in it in a small way?

Is the kernel-janitors mailing list a good way to start contributing
in a small way ?

> Sarah Sharp
>
> On Wed, Aug 31, 2011 at 04:44:35PM +0530, Sifram Rajas wrote:
>> From: Sifram Rajas <Sifram Rajas sifram.rajas@xxxxxxxxx>
>>
>> The xhci_hcd->devs is an array of pointers rather than pointer to pointer.
>> Hence this check is not required.
>>
>> Signed-off-by: Sifram Rajas <Sifram Rajas sifram.rajas@xxxxxxxxx>
>> ---
>>  drivers/usb/host/xhci.c |    3 +--
>>  1 files changed, 1 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
>> index 3a0f695..18db1a7 100644
>> --- a/drivers/usb/host/xhci.c
>> +++ b/drivers/usb/host/xhci.c
>> @@ -945,8 +945,7 @@ static int xhci_check_args(struct usb_hcd *hcd, struct usb_device *udev,
>>               return -ENODEV;
>>
>>       if (check_virt_dev) {
>> -             if (!udev->slot_id || !xhci->devs
>> -                     || !xhci->devs[udev->slot_id]) {
>> +             if (!udev->slot_id || !xhci->devs[udev->slot_id]) {
>>                       printk(KERN_DEBUG "xHCI %s called with unaddressed "
>>                                               "device\n", func);
>>                       return -EINVAL;
>> --
>> 1.7.4.1
>>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux