On Mon, Aug 29, 2011 at 3:36 PM, Sergei Shtylyov <sshtylyov@xxxxxxxxxx> wrote:
> Hello.
>
> On 29-08-2011 1:21, Sebastian Andrzej Siewior wrote:
>
>> Use platform helper to obtain irq& mem region instead OF helper. We get a
>> complete platform device out of every OF node so there is no need to use
>> OF helper for the standarf stuff.
>
>> Signed-off-by: Sebastian Andrzej Siewior<sebastian@xxxxxxxxxxxxx>
>> ---
>> drivers/usb/host/ehci-xilinx-of.c | 16 ++++++++--------
there are some OF functions used in file drivers/usb/host/ehci-grlib.c
as well. Is there any reason why you dint modify ehci-grlib.c?
>> 1 files changed, 8 insertions(+), 8 deletions(-)
>
>> diff --git a/drivers/usb/host/ehci-xilinx-of.c
>> b/drivers/usb/host/ehci-xilinx-of.c
>> index 8deebb8..2241935 100644
>> --- a/drivers/usb/host/ehci-xilinx-of.c
>> +++ b/drivers/usb/host/ehci-xilinx-of.c
>
> [...]
>>
>> @@ -185,9 +185,9 @@ static int __devinit ehci_hcd_xilinx_of_probe(struct
>> platform_device *op)
>> goto err_rmr;
>> }
>>
>> - irq = irq_of_parse_and_map(dn, 0);
>> + irq = platform_get_irq(op, 0);
>> if (irq == NO_IRQ) {
>
> No, platform_get_irq() returns -ENXIO on failure. NO_IRQ is defined as 0
> on PPC, IIRC.
>
> WBR, Sergei
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
