On Thu, Jul 07, 2011 at 05:01:47PM +0900, kuninori.morimoto.gx@xxxxxxxxxxx wrote: > > Dear Felipe > > Thank you for your reply > > > you don't need to quote the entire commit log, something like: > > > > commit 193ab2a6 (usb: gadget: allow multiple gadgets to be built) > > > > is enough. > > OK. I remove it in v2 patch > > (I added it because some other maintainer ordered me to quote it in git log) > > > > +# drivers/usb/renesas_usbhs/ > > > +config USB_RENESAS_USBHS > > > + bool > > > > I'm not sure this is enough. That symbol should be tristate too. Is that > > OK. I modify it to tristate in v2 patch > > > renesas controller really Dual-Role capable ? I only found > > gadget-related functions. If that's the case, then you might change your > > Makefile instead: > > Sorry. It still not supported for now. > But I will support it soon ok, so it is DRD. In that case, you need a symbol which depends on host and gadget and enables always compiles the whole thing. How does that sound ? Then remove from the gadget controller list as it won't be necessary. Something like what I did for the USB3 controller on OMAP5 (still out of tree, sorry): http://git.kernel.org/?p=linux/kernel/git/balbi/usb.git;a=blob;f=drivers/usb/dwc3/Kconfig;h=3c1d67d324fd473c07989286c119a0a23cf0d4de;hb=refs/heads/dwc3 (see that that is depends on (USB || USB_GADGET) while it should have been depends on (USB && USB_GADGET). I'll go fix that :-) -- balbi
Attachment:
signature.asc
Description: Digital signature
