Re: [PATCH] usb: renesas_usbhs: compile/config are rescued

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Dear Felipe

Thank you for your reply

> ok, so it is DRD. In that case, you need a symbol which depends on host
> and gadget and enables always compiles the whole thing. How does that
> sound ? Then remove from the gadget controller list as it won't be
> necessary. Something like what I did for the USB3 controller on OMAP5
> (still out of tree, sorry):
> 
> http://git.kernel.org/?p=linux/kernel/git/balbi/usb.git;a=blob;f=drivers/usb/dwc3/Kconfig;h=3c1d67d324fd473c07989286c119a0a23cf0d4de;hb=refs/heads/dwc3
> 
> (see that that is depends on (USB || USB_GADGET) while it should have
> been depends on (USB && USB_GADGET). I'll go fix that :-)

Haha =)

Cool. good idea.
I will use this style in v2 patc...

Oops. 

renesas_usbhs can use both Host/Gadget in some SuperH chip.
But some chip cannot.
 -> sometimes Host only
    sometimes Gadget only
    sometimes Host/Gadget

And my "mod_gadget" and "mod_host (coming soon)" are removable(?) style

Does below make sense ?

renesas_usbhs.ko will be created from USB_RENESAS_USBHS (tristate)
Gadget support came from USBHS_UDC which is bool

------------
config USB_RENESAS_USBHS
	tristate 'Renesas USBHS controller'
	depends on SUPERH || ARCH_SHMOBILE
	default n

config USB_RENESAS_USBHS_UDC
	bool 'Renesas USBHS controller'
	depends on SUPERH || ARCH_SHMOBILE
	depends on USB_RENESAS_USBHS
	select USB_GADGET_DUALSPEED

---------------
obj-$(CONFIG_USB_RENESAS_USBHS)	+= renesas_usbhs.o

renesas_usbhs-y			:= common.o mod.o pipe.o fifo.o

renesas_usbhs-$(CONFIG_USB_RENESAS_USBHS_UDC)	+= mod_gadget.o


Best regards
---
Kuninori Morimoto
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux