Re: [PATCH] usb: renesas_usbhs: compile/config are rescued

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Thu, Jul 07, 2011 at 12:22:06AM -0700, Kuninori Morimoto wrote:
> This patch rescues renesas_usbhs from
> 
>     commit 193ab2a6070039e7ee2b9b9bebea754a7c52fd1b
>     Author: Felipe Balbi <balbi@xxxxxx>
>     Date:   Wed Jun 22 17:28:10 2011 +0300
> 
>     usb: gadget: allow multiple gadgets to be built
> 
>     now that we have the udc class, we can allow
>     multiple gadget controller drivers to be
>     compiled as modules. This will allow for
>     distro-like kernels for embedded devices.

you don't need to quote the entire commit log, something like:

commit 193ab2a6 (usb: gadget: allow multiple gadgets to be built)

is enough.

> diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig
> index 8cd999a..3ebd958 100644
> --- a/drivers/usb/Kconfig
> +++ b/drivers/usb/Kconfig
> @@ -166,4 +166,8 @@ source "drivers/usb/gadget/Kconfig"
>  
>  source "drivers/usb/otg/Kconfig"
>  
> +# drivers/usb/renesas_usbhs/
> +config USB_RENESAS_USBHS
> +	bool

I'm not sure this is enough. That symbol should be tristate too. Is that
renesas controller really Dual-Role capable ? I only found
gadget-related functions. If that's the case, then you might change your
Makefile instead:

diff --git a/drivers/usb/renesas_usbhs/Makefile b/drivers/usb/renesas_usbhs/Makefile
index ce08345..6f5d1d4 100644
--- a/drivers/usb/renesas_usbhs/Makefile
+++ b/drivers/usb/renesas_usbhs/Makefile
@@ -2,8 +2,6 @@
 # for Renesas USB
 #
 
-obj-$(CONFIG_USB_RENESAS_USBHS)        += renesas_usbhs.o
+obj-$(CONFIG_USB_RENESAS_USBHS_UDC)    += renesas_usbhs.o
 
-renesas_usbhs-y                        := common.o mod.o pipe.o fifo.o
-
-renesas_usbhs-$(CONFIG_USB_RENESAS_USBHS_UDC)  += mod_gadget.o
+renesas_usbhs-y                        := common.o mod.o pipe.o fifo.o mod_gadget.o

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux