Re: [PATCH 5/6] usb: r8a66597-udc: Make BUSWAIT configurable through platform data

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Yoshihiro Shimoda | 2011-07-07 09:58:09 [+0900]:

>Note that this patch assumes that b'0000 (0 wait, 2 access cycles) is
>rerely used and considered as invalid. If valid 'buswait' data is not
>provided by platform, initial b'1111 (15 waits, 17 access cycles) will
>be applied as a safe default.
>
>Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
>---
> drivers/usb/gadget/r8a66597-udc.c |    4 +++-
> include/linux/usb/r8a66597.h      |    3 +++
> 2 files changed, 6 insertions(+), 1 deletions(-)
>
>diff --git a/drivers/usb/gadget/r8a66597-udc.c b/drivers/usb/gadget/r8a66597-udc.c
>index 8712546..fcfd5c5 100644
>--- a/drivers/usb/gadget/r8a66597-udc.c
>+++ b/drivers/usb/gadget/r8a66597-udc.c
>@@ -576,7 +576,9 @@ static void init_controller(struct r8a66597 *r8a66597)
> 	u16 endian = r8a66597->pdata->endian ? BIGEND : 0;
>
> 	if (r8a66597->pdata->on_chip) {
>-		r8a66597_bset(r8a66597, 0x04, SYSCFG1);
>+		if (r8a66597->pdata->buswait)
>+			r8a66597_write(r8a66597, r8a66597->pdata->buswait,
>+					SYSCFG1);

Where is this 15 aka sane default applied?

> 		r8a66597_bset(r8a66597, HSE, SYSCFG0);
>
> 		r8a66597_bclr(r8a66597, USBE, SYSCFG0);
>

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux