On Wed, Jun 01, 2016 at 09:33:02PM +0200, Nathael Pajani wrote: > Hi ! > > On 01/06/2016 20:43, Greg KH wrote: > > On Wed, Jun 01, 2016 at 08:35:50PM +0200, Nathael Pajani wrote: > >> From: Nathael Pajani <nathael.pajani@xxxxxxx> > >> Date: Wed, 1 Jun 2016 20:35:50 +0200 > >> Subject: [PATCH 1/1] usb: Add SMSC/Microchip USB2514 HUB support. > > > > Why is this here in the body of the email? > > Because git generated them and you asked me to place the patch file within the body of the > email. > Section 14 of Documentation/SubmittingPatches also states that : > > The canonical patch _message body_ contains the following: > - A "from" line specifying the patch author (only needed if the person > sending the patch is not the author). But you are the author :) > So I thought that the format generated by git was the right one. You can use 'git send-email' to send your patch out and it will be in the correct format. Putting the date and subject again in the body of the text doesn't usually work so well. > >> Add SMSC/Microchip USB2514 HUB support. > >> Hub configuration made through I2C from host instead of external EEPROM. > >> Signed-off-by: Nathael Pajani <nathael.pajani@xxxxxxx> > > > > Can you put a new-line before your signed-off-by: line like all other > > commits are in the kernel tree? > > > >> --- /dev/null > >> +++ b/include/linux/platform_data/usb2514.h > > > > Hm, why are you using platform_data and not device tree? I don't think > > we are "allowed" to add any new code that relies on platform data > > anymore. > > I used usb3503 driver as an example, so I did the same. I tested using a declaration in a > device tree, so I'll try to find how to use the right names/interface within the kernel. > > I'll also check the patch using scripts/checkpatch.pl > > Maybe this should be added to the head of the Documentation/SubmittingPatches (I now can > see it under section 4 of the document about style checking, but if it does more, it > should be made more visible. It's a big document, it's hard to say everything in it in a "very visible" manner :) thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
