Re: [PATCH 1/1] usb: Add SMSC/Microchip USB2514 HUB support.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jun 01, 2016 at 08:35:50PM +0200, Nathael Pajani wrote:
> From: Nathael Pajani <nathael.pajani@xxxxxxx>
> Date: Wed, 1 Jun 2016 20:35:50 +0200
> Subject: [PATCH 1/1] usb: Add SMSC/Microchip USB2514 HUB support.

Why is this here in the body of the email?

> 
> Add SMSC/Microchip USB2514 HUB support.
> Hub configuration made through I2C from host instead of external EEPROM.
> Signed-off-by: Nathael Pajani <nathael.pajani@xxxxxxx>

Can you put a new-line before your signed-off-by: line like all other
commits are in the kernel tree?

> --- /dev/null
> +++ b/include/linux/platform_data/usb2514.h

Hm, why are you using platform_data and not device tree?  I don't think
we are "allowed" to add any new code that relies on platform data
anymore.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux