Hi !
On 01/06/2016 20:43, Greg KH wrote:
> On Wed, Jun 01, 2016 at 08:35:50PM +0200, Nathael Pajani wrote:
>> From: Nathael Pajani <nathael.pajani@xxxxxxx>
>> Date: Wed, 1 Jun 2016 20:35:50 +0200
>> Subject: [PATCH 1/1] usb: Add SMSC/Microchip USB2514 HUB support.
>
> Why is this here in the body of the email?
Because git generated them and you asked me to place the patch file within the body of the
email.
Section 14 of Documentation/SubmittingPatches also states that :
The canonical patch _message body_ contains the following:
- A "from" line specifying the patch author (only needed if the person
sending the patch is not the author).
So I thought that the format generated by git was the right one.
>>
>> Add SMSC/Microchip USB2514 HUB support.
>> Hub configuration made through I2C from host instead of external EEPROM.
>> Signed-off-by: Nathael Pajani <nathael.pajani@xxxxxxx>
>
> Can you put a new-line before your signed-off-by: line like all other
> commits are in the kernel tree?
>
>> --- /dev/null
>> +++ b/include/linux/platform_data/usb2514.h
>
> Hm, why are you using platform_data and not device tree? I don't think
> we are "allowed" to add any new code that relies on platform data
> anymore.
I used usb3503 driver as an example, so I did the same. I tested using a declaration in a
device tree, so I'll try to find how to use the right names/interface within the kernel.
I'll also check the patch using scripts/checkpatch.pl
Maybe this should be added to the head of the Documentation/SubmittingPatches (I now can
see it under section 4 of the document about style checking, but if it does more, it
should be made more visible.
I'll try to make it soon, at least as soon as I have more time available :(
+++
> thanks,
>
> greg k-h
--
Nathaël PAJANI - ED3L - Techno-Innov
Internet : http://www.ed3l.fr - http://www.techno-innov.fr
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
