RE: [RESEND PATCH v6 07/10] usb: chipidea: otg: enable HNP polling support for gadget and host

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

> -----Original Message-----
> From: linux-usb-owner@xxxxxxxxxxxxxxx [mailto:linux-usb-
> owner@xxxxxxxxxxxxxxx] On Behalf Of Jun Li
> Sent: Friday, February 19, 2016 10:49 PM
> To: Felipe Balbi <balbif@xxxxxxxxx>; balbi@xxxxxxxxxx; Peter Chen
> <peter.chen@xxxxxxx>
> Cc: linux-usb@xxxxxxxxxxxxxxx
> Subject: RE: [RESEND PATCH v6 07/10] usb: chipidea: otg: enable HNP
> polling support for gadget and host
> 
> Hi Felipe,
> 
> > -----Original Message-----
> > From: Felipe Balbi [mailto:balbif@xxxxxxxxx]
> > Sent: Friday, February 19, 2016 10:07 PM
> > To: Jun Li <jun.li@xxxxxxx>; balbi@xxxxxxxxxx; Peter Chen
> > <peter.chen@xxxxxxx>
> > Cc: linux-usb@xxxxxxxxxxxxxxx; Jun Li <jun.li@xxxxxxx>
> > Subject: Re: [RESEND PATCH v6 07/10] usb: chipidea: otg: enable HNP
> > polling support for gadget and host
> >
> >
> > hi,
> >
> > Li Jun <jun.li@xxxxxxx> writes:
> > > Enable HNP polling support for chipidea gadget and allocate memory
> > > for host request flag when otg fsm init.
> > >
> > > Acked-by: Peter Chen <peter.chen@xxxxxxx>
> > > Signed-off-by: Li Jun <jun.li@xxxxxxx>
> >
> > Why do you guys do this to me ? It's v6 and this thing still doesn't
> > compile. Why even send stuff you haven't even compile tested ???? Why ???
> 
> I certainly tested my patch set on multiple i.MX6 platforms, so, the build
> is ok in my side.
> 
> >
> > > ---
> > >  drivers/usb/chipidea/otg_fsm.c | 4 ++++
> > >  1 file changed, 4 insertions(+)
> > >
> > > diff --git a/drivers/usb/chipidea/otg_fsm.c
> > > b/drivers/usb/chipidea/otg_fsm.c index cb28e76..9a963a7 100644
> > > --- a/drivers/usb/chipidea/otg_fsm.c
> > > +++ b/drivers/usb/chipidea/otg_fsm.c
> > > @@ -797,6 +797,10 @@ int ci_hdrc_otg_fsm_init(struct ci_hdrc *ci)
> > >  	ci->fsm.id = hw_read_otgsc(ci, OTGSC_ID) ? 1 : 0;
> > >  	ci->fsm.otg->state = OTG_STATE_UNDEFINED;
> > >  	ci->fsm.ops = &ci_otg_ops;
> > > +	ci->gadget.hnp_polling_support = 1;
> > > +	ci->fsm.host_req_flag = devm_kzalloc(ci->dev, 1, GFP_KERNEL);
> > > +	if (!ci->fsm.host_req_flag)
> >
> > the name of the flag is host_request_flag, not host_req_flag. Now, how
> > can I be certain you really tested this at all ? I won't accept this
> > without hard-proof of this really working.
> 
> Nope, the flag is host_req_flag, not "host_request_flag" as you said, See
> my patch 3/7:
> [RESEND PATCH v6 03/10] usb: common: otg-fsm: add HNP polling support
> 
> @@ -119,6 +131,8 @@ struct otg_fsm {
>         /* Current usb protocol used: 0:undefine; 1:host; 2:client */
>         int protocol;
>         struct mutex lock;
> +       u8 *host_req_flag;
> +       struct delayed_work hnp_polling_work;
>  };
> 
> 
> >
> > Sorry guys, but it's v6 of this patch series and we're still having
> > build issues.
> >
> 
> I don't know why you has this build issue, I created my patchset against
> Peter's chipidea tree(ci-for-usb-next branch). I will apply my patches to
> your tree(testing_next) and try again.
> 

Also NO build issue found with my patchset on your tree(testing/next branch).

> Li Jun
> 
> > make -k -j8 -- drivers/usb/
> >   CHK     include/config/kernel.release
> >   CHK     include/generated/uapi/linux/version.h
> >   UPD     include/config/kernel.release
> >   CHK     include/generated/utsrelease.h
> >   UPD     include/generated/utsrelease.h
> >   CHK     include/generated/timeconst.h
> >   CHK     include/generated/bounds.h
> >   CHK     include/generated/asm-offsets.h
> >   CALL    scripts/checksyscalls.sh
> >   CC [M]  drivers/usb/chipidea/otg_fsm.o
> > drivers/usb/chipidea/otg_fsm.c: In function ‘ci_hdrc_otg_fsm_init’:
> > drivers/usb/chipidea/otg_fsm.c:801:9: error: ‘struct otg_fsm’ has no
> > member named ‘host_req_flag’
> >   ci->fsm.host_req_flag = devm_kzalloc(ci->dev, 1, GFP_KERNEL);
> >          ^
> > drivers/usb/chipidea/otg_fsm.c:802:14: error: ‘struct otg_fsm’ has no
> > member named ‘host_req_flag’
> >   if (!ci->fsm.host_req_flag)
> >               ^
> > scripts/Makefile.build:258: recipe for target
> > 'drivers/usb/chipidea/otg_fsm.o' failed
> > make[2]: *** [drivers/usb/chipidea/otg_fsm.o] Error 1
> > make[2]: Target '__build' not remade because of errors.
> > scripts/Makefile.build:407: recipe for target 'drivers/usb/chipidea'
> > failed
> > make[1]: *** [drivers/usb/chipidea] Error 2
> > make[1]: Target '__build' not remade because of errors.
> > Makefile:1557: recipe for target 'drivers/usb/' failed
> > make: *** [drivers/usb/] Error 2
> >
> > --
> > balbi
>  {.n +       +%  lzwm  b 맲  r  zX   n)   w*jg        ݢj/   z ޖ  2 ޙ
> & )ߡ a     G   h  j:+v   w ٥
��.n��������+%������w��{.n�����{���)��jg��������ݢj����G�������j:+v���w�m������w�������h�����٥




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux