hi,
Li Jun <jun.li@xxxxxxx> writes:
> Enable HNP polling support for chipidea gadget and allocate memory
> for host request flag when otg fsm init.
>
> Acked-by: Peter Chen <peter.chen@xxxxxxx>
> Signed-off-by: Li Jun <jun.li@xxxxxxx>
Why do you guys do this to me ? It's v6 and this thing still doesn't
compile. Why even send stuff you haven't even compile tested ???? Why ???
> ---
> drivers/usb/chipidea/otg_fsm.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/usb/chipidea/otg_fsm.c b/drivers/usb/chipidea/otg_fsm.c
> index cb28e76..9a963a7 100644
> --- a/drivers/usb/chipidea/otg_fsm.c
> +++ b/drivers/usb/chipidea/otg_fsm.c
> @@ -797,6 +797,10 @@ int ci_hdrc_otg_fsm_init(struct ci_hdrc *ci)
> ci->fsm.id = hw_read_otgsc(ci, OTGSC_ID) ? 1 : 0;
> ci->fsm.otg->state = OTG_STATE_UNDEFINED;
> ci->fsm.ops = &ci_otg_ops;
> + ci->gadget.hnp_polling_support = 1;
> + ci->fsm.host_req_flag = devm_kzalloc(ci->dev, 1, GFP_KERNEL);
> + if (!ci->fsm.host_req_flag)
the name of the flag is host_request_flag, not host_req_flag. Now, how
can I be certain you really tested this at all ? I won't accept this
without hard-proof of this really working.
Sorry guys, but it's v6 of this patch series and we're still having
build issues.
make -k -j8 -- drivers/usb/
CHK include/config/kernel.release
CHK include/generated/uapi/linux/version.h
UPD include/config/kernel.release
CHK include/generated/utsrelease.h
UPD include/generated/utsrelease.h
CHK include/generated/timeconst.h
CHK include/generated/bounds.h
CHK include/generated/asm-offsets.h
CALL scripts/checksyscalls.sh
CC [M] drivers/usb/chipidea/otg_fsm.o
drivers/usb/chipidea/otg_fsm.c: In function ‘ci_hdrc_otg_fsm_init’:
drivers/usb/chipidea/otg_fsm.c:801:9: error: ‘struct otg_fsm’ has no member named ‘host_req_flag’
ci->fsm.host_req_flag = devm_kzalloc(ci->dev, 1, GFP_KERNEL);
^
drivers/usb/chipidea/otg_fsm.c:802:14: error: ‘struct otg_fsm’ has no member named ‘host_req_flag’
if (!ci->fsm.host_req_flag)
^
scripts/Makefile.build:258: recipe for target 'drivers/usb/chipidea/otg_fsm.o' failed
make[2]: *** [drivers/usb/chipidea/otg_fsm.o] Error 1
make[2]: Target '__build' not remade because of errors.
scripts/Makefile.build:407: recipe for target 'drivers/usb/chipidea' failed
make[1]: *** [drivers/usb/chipidea] Error 2
make[1]: Target '__build' not remade because of errors.
Makefile:1557: recipe for target 'drivers/usb/' failed
make: *** [drivers/usb/] Error 2
--
balbi
Attachment:
signature.asc
Description: PGP signature
