Hi,
Jun Li <jun.li@xxxxxxx> writes:
>> > Li Jun <jun.li@xxxxxxx> writes:
>> > > Enable HNP polling support for chipidea gadget and allocate memory
>> > > for host request flag when otg fsm init.
>> > >
>> > > Acked-by: Peter Chen <peter.chen@xxxxxxx>
>> > > Signed-off-by: Li Jun <jun.li@xxxxxxx>
>> >
>> > Why do you guys do this to me ? It's v6 and this thing still doesn't
>> > compile. Why even send stuff you haven't even compile tested ???? Why ???
>>
>> I certainly tested my patch set on multiple i.MX6 platforms, so, the build
>> is ok in my side.
>>
>> >
>> > > ---
>> > > drivers/usb/chipidea/otg_fsm.c | 4 ++++
>> > > 1 file changed, 4 insertions(+)
>> > >
>> > > diff --git a/drivers/usb/chipidea/otg_fsm.c
>> > > b/drivers/usb/chipidea/otg_fsm.c index cb28e76..9a963a7 100644
>> > > --- a/drivers/usb/chipidea/otg_fsm.c
>> > > +++ b/drivers/usb/chipidea/otg_fsm.c
>> > > @@ -797,6 +797,10 @@ int ci_hdrc_otg_fsm_init(struct ci_hdrc *ci)
>> > > ci->fsm.id = hw_read_otgsc(ci, OTGSC_ID) ? 1 : 0;
>> > > ci->fsm.otg->state = OTG_STATE_UNDEFINED;
>> > > ci->fsm.ops = &ci_otg_ops;
>> > > + ci->gadget.hnp_polling_support = 1;
>> > > + ci->fsm.host_req_flag = devm_kzalloc(ci->dev, 1, GFP_KERNEL);
>> > > + if (!ci->fsm.host_req_flag)
>> >
>> > the name of the flag is host_request_flag, not host_req_flag. Now, how
>> > can I be certain you really tested this at all ? I won't accept this
>> > without hard-proof of this really working.
>>
>> Nope, the flag is host_req_flag, not "host_request_flag" as you said, See
>> my patch 3/7:
>> [RESEND PATCH v6 03/10] usb: common: otg-fsm: add HNP polling support
>>
>> @@ -119,6 +131,8 @@ struct otg_fsm {
>> /* Current usb protocol used: 0:undefine; 1:host; 2:client */
>> int protocol;
>> struct mutex lock;
>> + u8 *host_req_flag;
>> + struct delayed_work hnp_polling_work;
>> };
>>
>>
>> >
>> > Sorry guys, but it's v6 of this patch series and we're still having
>> > build issues.
>> >
>>
>> I don't know why you has this build issue, I created my patchset against
>> Peter's chipidea tree(ci-for-usb-next branch). I will apply my patches to
>> your tree(testing_next) and try again.
>>
>
> Also NO build issue found with my patchset on your tree(testing/next
> branch).
no way, second time this happens. Just tried applying again and it's all
building fine. Sorry about that
--
balbi
Attachment:
signature.asc
Description: PGP signature
