Re: [RFC 2/2] usb: core: allow a reference device for new_id

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Jan 12, 2014 at 10:11:54AM +0100, Wolfram Sang wrote:
> 
> > > I also wonder if we should return an error to the user in case we don't
> > > find a matching reference entry?  It will otherwise be very difficult
> > > for the user to catch typos.
> > 
> > Ah, yeah, that would be a good idea, Wofram, care to do an add-on patch
> > for that?
> 
> Just sent. Another question: Can usb_drv->id_table be NULL in drivers?
> I was assuming it can't, because it is needed for matching, Yet, my
> assumption may be wrong and then I'd need to check for this.

Yes, it can, if you look at the comment in usb_match_id(), we have to
check for this there.  So I think you should check for this as well in
your change as well.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux