Re: [RFC 00/48] perf tools: Introduce data type profiling (v1)
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [RFC 00/48] perf tools: Introduce data type profiling (v1)
- From: Namhyung Kim <namhyung@xxxxxxxxxx>
- Date: Tue, 24 Oct 2023 22:51:41 -0700
- Cc: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>, Jiri Olsa <jolsa@xxxxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Ian Rogers <irogers@xxxxxxxxxx>, Adrian Hunter <adrian.hunter@xxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, LKML <linux-kernel@xxxxxxxxxxxxxxx>, linux-perf-users@xxxxxxxxxxxxxxx, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, Stephane Eranian <eranian@xxxxxxxxxx>, Masami Hiramatsu <mhiramat@xxxxxxxxxx>, linux-toolchains@xxxxxxxxxxxxxxx, linux-trace-devel@xxxxxxxxxxxxxxx, Ben Woodard <woodard@xxxxxxxxxx>, Joe Mario <jmario@xxxxxxxxxx>, Kees Cook <keescook@xxxxxxxxxxxx>, David Blaikie <blaikie@xxxxxxxxxx>, Xu Liu <xliuprof@xxxxxxxxxx>, Kan Liang <kan.liang@xxxxxxxxxxxxxxx>, Ravi Bangoria <ravi.bangoria@xxxxxxx>
- In-reply-to: <ZTh41epbjwGsMPaB@tassilo>
- References: <20231012035111.676789-1-namhyung@kernel.org> <87pm15vw5r.fsf@linux.intel.com> <CAM9d7ch504cnFzTL1qPh349uSrbEZop19kB-DbUsnoOKEvtFBQ@mail.gmail.com> <ZTh41epbjwGsMPaB@tassilo>
On Tue, Oct 24, 2023 at 7:09 PM Andi Kleen <ak@xxxxxxxxxxxxxxx> wrote:
>
> >
> > >
> > > The main difference seems to be that mine was more for perf script
> > > (e.g. i supported PT decoding), while you are more focused on sampling.
> > > I relied on the kprobes/uprobes engine, which unfortunately was always
> > > quite slow and had many limitations.
> >
> > Right, I think dealing with regular samples would be more useful.
>
> My code supported samples too, but only through perf script, not report.
>
> See
>
> https://git.kernel.org/pub/scm/linux/kernel/git/ak/linux-misc.git/commit/?h=perf/var-resolve-7&id=4775664750a6296acb732b7adfa224c6a06a126f
>
> for an example.
>
> My take was that i wasn't sure that perf report is the right interface
> to visualize the variables changing -- to be really usable you probably
> need some plots and likely something like an UI.
I see. Your concern is to see how variables are changing.
But it seems you only displayed constant values.
>
> For you I think you focus more on the types than the individual
> variables? That's a slightly different approach.
Right, you can see which fields in a struct are accessed
mostly and probably change the layout for better result.
>
> But then my engine had a lot of limitations, i suppose redoing that on
> top of yours would give better results.
Sounds good, thanks.
Namhyung
[Index of Archives]
[Linux USB Development]
[Linux USB Development]
[Linux Audio Users]
[Yosemite Hiking]
[Linux Kernel]
[Linux SCSI]