Hi Luc, On 13 August 2017 at 16:07, Luc Van Oostenryck <luc.vanoostenryck@xxxxxxxxx> wrote: > On Sun, Aug 13, 2017 at 4:26 PM, Dibyendu Majumdar > <mobile@xxxxxxxxxxxxxxx> wrote: >>> >>> It's also interesting to note that with the new SSA construction, there is no >>> slowdown (0.064s here but too small to be measured accurately). >>> This confirms me that the single-store shortcut was very much needed for >>> performance (not simply because it's faster than the general case but that >>> it creates much less intermediate code) but it created bad code ... >>> >> >> I wonder if it is worth doing these changes - instead we should >> probably look at your new SSA construction approach. > > It was of course what I was thinking when I wrote this note. > > I've put together the minimal changes for having this on top > of the current master: > git://github.com/lucvoo/sparse.git sssa-mini > > Since yesterday I already gave it a good more testing and > everything good so far. > That's great. I would recommend getting the current release out by undoing the single store shortcut change - and then immediately after that your SSA construction should become the main focus as it will help avoid wasting time on other issues. In any case I will give your changes a try in my repository and let you know if I face any issues. Regards Dibyendu -- To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html