On Sun, Aug 13, 2017 at 2:56 PM, Dibyendu Majumdar <mobile@xxxxxxxxxxxxxxx> wrote: > Hi Chris & Luc, > Hi, > > I am merging and testing this in my repository. I notice that after > applying the changes related to killing of BBs - there is a > significant slow down in Sparse. > > Before the merge: > > real: 4.3 minutes > user: 4.1 minutes > > After the merge: > > real: 18.9 minutes > user: 18.7 minutes > > I just noticed this and these are my initial tests. But I thought it > worth letting you know. I very small slowdown is expected (and even it could have positive effect too) but not at all something like this. And what I (and I think Chris too) measured was indeed quite small. Care to send your code, I can see where the problem could be? > BTW in my tests I do not see any change in the results after the > changes - i.e. the previous failures due to simplification are still > present. But there is now a degradation in performance - so my > question is - are these changes worthwhile? This change (well I guess we're talking about the same) is needed to ensure consistency: avoid to do things in unreachable code where the conditions to do those things are not met and thus problems follow. -- Luc -- To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
