Hi, On 17.02.22 at 12:47, Lukas Wunner wrote: > On Wed, Feb 16, 2022 at 01:17:58AM +0100, Lino Sanfilippo wrote: >> --- a/drivers/tty/serial/sc16is7xx.c >> +++ b/drivers/tty/serial/sc16is7xx.c >> @@ -959,16 +959,6 @@ static int sc16is7xx_config_rs485(struct uart_port *port, >> struct sc16is7xx_one *one = to_sc16is7xx_one(port, port); >> >> if (rs485->flags & SER_RS485_ENABLED) { >> - bool rts_during_rx, rts_during_tx; >> - >> - rts_during_rx = rs485->flags & SER_RS485_RTS_AFTER_SEND; >> - rts_during_tx = rs485->flags & SER_RS485_RTS_ON_SEND; >> - >> - if (rts_during_rx == rts_during_tx) >> - dev_err(port->dev, >> - "unsupported RTS signalling on_send:%d after_send:%d - exactly one of RS485 RTS flags should be set\n", >> - rts_during_tx, rts_during_rx); >> - > > Hm, patch 1 in this series doesn't emit such a message, so unlike now, > users will no longer be warned that they passed in nonsensical settings... > what about logging a warning for both RTS polarity and delay correction? Regards, Lino