Re: [PATCH 1/2] tty: serial: jsm: Remove unnecessary NULL checks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Dec 22, 2017 at 06:17:15PM -0200, Guilherme G. Piccoli wrote:
> On 12/22/2017 05:20 PM, SF Markus Elfring wrote:
> >> After discussion in mailing list, …
> > 
> > Thanks that you extended the commit description with a bit
> > of background information.
> > 
> > 
> >> These two unnecessary NULL checks were tracked in the call
> >> chain as never NULL, …
> > 
> > I find this wording too generic.
> > How do you think about to point the function(s) out exactly
> > which call the discussed function implementations?
> 
> It's on the code Markus, no need to put this on commit message.
> Commit messages aren't meant to describe what code changes were done,
> just to specify why and how (in a theoretical way).

Please note, you are arguing with someone who is on many kernel
maintainers's, including myself, email blacklist, for this pointless
type of dicusssion.  I'd recommend adding them to your own list to save
you time and energy.

good luck!

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux