On 12/22/2017 05:20 PM, SF Markus Elfring wrote: >> After discussion in mailing list, … > > Thanks that you extended the commit description with a bit > of background information. > > >> These two unnecessary NULL checks were tracked in the call >> chain as never NULL, … > > I find this wording too generic. > How do you think about to point the function(s) out exactly > which call the discussed function implementations? It's on the code Markus, no need to put this on commit message. Commit messages aren't meant to describe what code changes were done, just to specify why and how (in a theoretical way). > > >> No functional changes are intended. > > Did we agree already that such an information could be questionable? > https://lkml.kernel.org/r/<e456697b-c412-4de6-a1dd-95ec4a219c68@xxxxxxxxxxxxxxxxxx> > > Is another approach needed to achieve the desired consensus? I didn't agree with this - I mean, no functional change was intended, it's a fact. Do we agree that the NULL checks were useless? If yes (and we do, since it was your suggestion), how removing them will change the function of adapter/driver? So, no functional change should happen after this patch. Cheers, Guilherme > > Regards, > Markus > -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
