On 12/23/2017 07:29 AM, Greg Kroah-Hartman wrote: > On Fri, Dec 22, 2017 at 06:17:15PM -0200, Guilherme G. Piccoli wrote: >> On 12/22/2017 05:20 PM, SF Markus Elfring wrote: >>>> After discussion in mailing list, … >>> >>> Thanks that you extended the commit description with a bit >>> of background information. >>> >>> >>>> These two unnecessary NULL checks were tracked in the call >>>> chain as never NULL, … >>> >>> I find this wording too generic. >>> How do you think about to point the function(s) out exactly >>> which call the discussed function implementations? >> >> It's on the code Markus, no need to put this on commit message. >> Commit messages aren't meant to describe what code changes were done, >> just to specify why and how (in a theoretical way). > > Please note, you are arguing with someone who is on many kernel > maintainers's, including myself, email blacklist, for this pointless > type of dicusssion. I'd recommend adding them to your own list to save > you time and energy. > > good luck! Heheh thanks Greg! Yeah, I was trying to make a civilized discussion, but it's impossible to argue over such amount of bike-shedding about trivial stuff... My patience reached its maximum, I'm starting to think it's a kind of sophisticated troll technique heheh Anyway, I won't be able to iterate this patch anymore, so if you think it's appropriate and "mergeable", I'd be thankful! Although trivial, it seems a good addition. Otherwise, If you dislike it, just drop the patches, they aren't essential, of course. Thanks, and have a happy new year. Cheers, Guilherme > > greg k-h > -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
