On 10/11/2022 12:18, Vivek Yadav wrote: >>> +maintainers: >>> + - Alim Akhtar <alim.akhtar@xxxxxxxxxxx> >>> + >>> +description: | >>> + This is a system control registers block, providing multiple low >>> +level >>> + platform functions like board detection and identification, >>> +software >>> + interrupt generation. >>> + >>> +properties: >>> + compatible: >>> + oneOf: >> >> No need for oneOf. >> > Removing this results into dt_binding_check error, so this is required. No, this is not required. You do not have more than one condition for oneOf. >>> + - items: >>> + - enum: >>> + - tesla,sysreg_fsys0 >>> + - tesla,sysreg_peric >> >> From where did you get underscores in compatibles? >> > I have seen in MCAN Driver <drivers/net/can/m_can/m_can_platform.c> and also too many other yaml files. > Do you have any ref standard guideline of compatible which says underscore is not allowed. git grep compatible arch/arm64/boot/dts/exynos/ | grep _ git grep compatible arch/arm/boot/dts/exynos* | grep _ Both give 0 results. For few other SoCs there such cases but that's really, really exception. Drop underscores. Best regards, Krzysztof
