On 09/11/2022 11:09, Vivek Yadav wrote: > From: Sriranjani P <sriranjani.p@xxxxxxxxxxx> > Use subject prefixes matching the subsystem (git log --oneline -- ...). > Describe the compatible properties for SYSREG controllers found on > FSD SoC. This is ARM SoC patch, split it from the patchset. > > Signed-off-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx> > Signed-off-by: Pankaj Kumar Dubey <pankaj.dubey@xxxxxxxxxxx> > Signed-off-by: Ravi Patel <ravi.patel@xxxxxxxxxxx> > Signed-off-by: Vivek Yadav <vivek.2311@xxxxxxxxxxx> > Cc: devicetree@xxxxxxxxxxxxxxx > Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx> > Cc: Rob Herring <robh+dt@xxxxxxxxxx> Drop the Cc list from commit log. It's not helpful. > Signed-off-by: Sriranjani P <sriranjani.p@xxxxxxxxxxx> > --- > .../devicetree/bindings/arm/tesla-sysreg.yaml | 50 +++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 51 insertions(+) > create mode 100644 Documentation/devicetree/bindings/arm/tesla-sysreg.yaml > > diff --git a/Documentation/devicetree/bindings/arm/tesla-sysreg.yaml b/Documentation/devicetree/bindings/arm/tesla-sysreg.yaml > new file mode 100644 > index 000000000000..bbcc6dd75918 > --- /dev/null > +++ b/Documentation/devicetree/bindings/arm/tesla-sysreg.yaml arm is only for top level stuff. This goes to soc under tesla or samsung directory. > @@ -0,0 +1,50 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/arm/tesla-sysreg.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Tesla Full Self-Driving platform's system registers > + > +maintainers: > + - Alim Akhtar <alim.akhtar@xxxxxxxxxxx> > + > +description: | > + This is a system control registers block, providing multiple low level > + platform functions like board detection and identification, software > + interrupt generation. > + > +properties: > + compatible: > + oneOf: No need for oneOf. > + - items: > + - enum: > + - tesla,sysreg_fsys0 > + - tesla,sysreg_peric >From where did you get underscores in compatibles? > + - const: syscon > + > + reg: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + soc { > + #address-cells = <2>; > + #size-cells = <2>; > + > + sysreg_fsys0: system-controller@15030000 { > + compatible = "tesla,sysreg_fsys0", "syscon"; Use 4 spaces for example indentation. > + reg = <0x0 0x15030000 0x0 0x1000>; > + }; > + > + sysreg_peric: system-controller@14030000 { > + compatible = "tesla,sysreg_peric", "syscon"; > + reg = <0x0 0x14030000 0x0 0x1000>; > + }; One example is enough, they are the same. > + }; > diff --git a/MAINTAINERS b/MAINTAINERS > index a198da986146..56995e7d63ad 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -2943,6 +2943,7 @@ M: linux-fsd@xxxxxxxxx > L: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx (moderated for non-subscribers) > L: linux-samsung-soc@xxxxxxxxxxxxxxx > S: Maintained > +F: Documentation/devicetree/bindings/arm/tesla-sysreg.yaml > F: arch/arm64/boot/dts/tesla* > > ARM/TETON BGA MACHINE SUPPORT Best regards, Krzysztof
