> -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > Sent: 10 November 2022 17:42 > To: Vivek Yadav <vivek.2311@xxxxxxxxxxx>; rcsekar@xxxxxxxxxxx; > krzysztof.kozlowski+dt@xxxxxxxxxx; wg@xxxxxxxxxxxxxx; > mkl@xxxxxxxxxxxxxx; davem@xxxxxxxxxxxxx; edumazet@xxxxxxxxxx; > kuba@xxxxxxxxxx; pabeni@xxxxxxxxxx; pankaj.dubey@xxxxxxxxxxx; > ravi.patel@xxxxxxxxxxx; alim.akhtar@xxxxxxxxxxx; linux-fsd@xxxxxxxxx; > robh+dt@xxxxxxxxxx > Cc: linux-can@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux- > samsung-soc@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; > aswani.reddy@xxxxxxxxxxx; sriranjani.p@xxxxxxxxxxx > Subject: Re: [PATCH v2 1/6] dt-bindings: Document the SYSREG specific > compatibles found on FSD SoC > > On 10/11/2022 12:18, Vivek Yadav wrote: > >>> +maintainers: > >>> + - Alim Akhtar <alim.akhtar@xxxxxxxxxxx> > >>> + > >>> +description: | > >>> + This is a system control registers block, providing multiple low > >>> +level > >>> + platform functions like board detection and identification, > >>> +software > >>> + interrupt generation. > >>> + > >>> +properties: > >>> + compatible: > >>> + oneOf: > >> > >> No need for oneOf. > >> > > Removing this results into dt_binding_check error, so this is required. > > No, this is not required. You do not have more than one condition for oneOf. > Oh, ok I got it. I was not removing "-" before items, which is resulting an error. I will update this in next patch series. Sorry for confusion. > >>> + - items: > >>> + - enum: > >>> + - tesla,sysreg_fsys0 > >>> + - tesla,sysreg_peric > >> > >> From where did you get underscores in compatibles? > >> > > I have seen in MCAN Driver <drivers/net/can/m_can/m_can_platform.c> > and also too many other yaml files. > > Do you have any ref standard guideline of compatible which says > underscore is not allowed. > > git grep compatible arch/arm64/boot/dts/exynos/ | grep _ git grep > compatible arch/arm/boot/dts/exynos* | grep _ > > Both give 0 results. For few other SoCs there such cases but that's really, > really exception. Drop underscores. > git grep compatible arch/arm64/boot/dts/ | grep _ | wc -l This gives me 456 location, am I missing anything here ? Anyway I will replace with "-" in next patch series. > > Best regards, > Krzysztof Thanks for review the patches.
